]> git.cworth.org Git - empires-server/commitdiff
Add a new "broadcast_event_object" method to accept an obejct not a string
authorCarl Worth <cworth@cworth.org>
Mon, 8 Jun 2020 13:57:22 +0000 (06:57 -0700)
committerCarl Worth <cworth@cworth.org>
Mon, 8 Jun 2020 13:57:22 +0000 (06:57 -0700)
I probably want this to be the default, (replacing broadcast_event
entirely, or perhaps renaming it to broadcast_event_string if there
are any users that do need to stick around).

With cases like this, I do wish I was using a type safe language to
avoid the confusion that comes with "Does this function want an object
or a string representation of that object?".

game.js

diff --git a/game.js b/game.js
index eb78f31ecbe531a38801cbbb9b4a466eb968d8cc..eb1ba807c3e1d9ec5a0e9eda65fceafaff052338 100644 (file)
--- a/game.js
+++ b/game.js
@@ -224,6 +224,10 @@ class Game {
     this.broadcast_string(`event: ${type}\ndata: ${data}\n`);
   }
 
+  broadcast_event_object(type, obj) {
+    this.broadcast_event(type, JSON.stringify(obj));
+  }
+
   handle_events(request, response) {
     /* These headers will keep the connection open so we can stream events. */
     const headers = {