]> git.cworth.org Git - lmno.games/commit
Eliminate lead-in text when there is nothing following
authorCarl Worth <cworth@cworth.org>
Sun, 28 Jun 2020 15:21:41 +0000 (08:21 -0700)
committerCarl Worth <cworth@cworth.org>
Sun, 28 Jun 2020 15:21:41 +0000 (08:21 -0700)
commit533300fbcbfec8c219901cbde2d9c6f336939f97
treee42851d7e07ea842002b92455bab902e805a2c8f
parentf8b6dc7aef51ccc82d163f015612c7640f0be365
Eliminate lead-in text when there is nothing following

I was often annoyed to see the text "Still waiting for the following
players:" when it was followed by no players at all.

It would have been really awkward to try to achieve the result of this
commit withing the final return statement. It's funny how often I
forget that JSX doesn't require all content to be contained in a
single return statement. I often find myself migrating to an approach
that can be seen in this commit, and I seem to prefer it:

  * Conditions are captured in JavaScript code, (and not within JSX)

  * Various React componenents are each captured in separate JSX chunks

  * The final return statement is often just listing previously
    constructed components
empathy/empathy.jsx