cppcheck: close files during shutdown

Fix the following cppcheck errors:

    notmuch-count.c:207: error: Resource leak: input
    notmuch-tag.c:238: error: Resource leak: input

We know that the program is shutting down here, but it does no harm to
clean up a bit.

diff --git a/notmuch-count.c b/notmuch-count.c
index 50b0c193f04625c794b9ab9287ab6bdd9c4f29da..97281374b22252059fcbf65ff28d426615b2a632 100644 (file)
--- a/notmuch-count.c
+++ b/notmuch-count.c
@@ -204,6 +204,8 @@ notmuch_count_command (notmuch_config_t *config, int argc, char *argv[])
 
     if (batch && opt_index != argc) {
        fprintf (stderr, "--batch and query string are not compatible\n");
+       if (input)
+           fclose (input);
        return EXIT_FAILURE;
     }
 

diff --git a/notmuch-tag.c b/notmuch-tag.c
index 9c03754d58568a04f9a7971d2296ab014c19f054..130de6343f8ec42bac91c7b6114e83ab2a4f854c 100644 (file)
--- a/notmuch-tag.c
+++ b/notmuch-tag.c
@@ -235,6 +235,8 @@ notmuch_tag_command (notmuch_config_t *config, int argc, char *argv[])
     if (batch) {
        if (opt_index != argc) {
            fprintf (stderr, "Can't specify both cmdline and stdin!\n");
+           if (input)
+               fclose (input);
            return EXIT_FAILURE;
        }
     } else {