Reword the Move On button when we're not waiting for anyone specific
authorCarl Worth <cworth@cworth.org>
Mon, 29 Jun 2020 15:32:51 +0000 (08:32 -0700)
committerCarl Worth <cworth@cworth.org>
Mon, 29 Jun 2020 15:32:51 +0000 (08:32 -0700)
This case arises when there are additional players still connected to
the game, but that haven't even started typing any answers.

In this case, the view looks like this:

Submission received

The following players have submitted their answers: <list>

In this case, wording of "Move On Without Their Answers" suggests the
exact opposite, (as if "their" is referring to the submitted players
rather than those not listed on this page). The new wording in this
case, "Move On Without Anyone Else" makes it more clear what the
behavior is.

empathy/empathy.jsx

index 2511250dd923ebfb2d9978c8e0c60e9e03a193d6..53d7763c84f7a27643ac5f90b935dd945c601335 100644 (file)
@@ -829,7 +829,9 @@ class ActivePrompt extends React.PureComponent {
           className="vote-button"
           onClick={() => fetch_post_json(`end-answers/${this.props.prompt.id}`) }
         >
-          Move On Without Their Answers
+          {answering_players.length ?
+           "Move On Without Their Answers" :
+           "Move On Without Anyone Else"}
           <div className="vote-choices">
             {[...this.props.votes].map(v => {
               return (