Add quotes in notmuch-attach script to handle correctly filenames with spaces

[notmuch-wiki] / emacstips.mdwn

diff --git a/emacstips.mdwn b/emacstips.mdwn
index 082c57290d5ab214b91b6d097a9d14bb192ba099..070edba3b653a318e2a515d5fcdf44bd1cf92c3e 100644 (file)
--- a/emacstips.mdwn
+++ b/emacstips.mdwn
@@ -87,7 +87,7 @@ mentioned as script arguments. (Note: The script expects that you have
         #!/bin/sh
         attach_cmds=""
         while [ "$1" ]; do
-            fullpath=$(readlink --canonicalize $1)
+            fullpath=$(readlink --canonicalize "$1")
             attach_cmds="$attach_cmds (mml-attach-file \"$fullpath\")"
             shift
         done
@@ -139,6 +139,8 @@ for making quick tag key bindings.  For instance, here's an example
 of how to make a key binding to add the "spam" tag and remove the
 "inbox" tag in notmuch-show-mode:
 
+In notmuch versions up to 0.11.x
+
         (define-key notmuch-show-mode-map "S"
           (lambda ()
             "mark message as spam"
@@ -146,9 +148,22 @@ of how to make a key binding to add the "spam" tag and remove the
             (notmuch-show-add-tag "spam")
             (notmuch-show-remove-tag "inbox")))
 
+Starting from notmuch 0.12 (not released yet) the functions 
+`notmuch-show-add-tag` and `notmuch-show-remove-tag` have changed to
+be more versatile and lost noninteractive use. When upgrading to 0.12 
+the above needs to be changed to this:
+
+        (define-key notmuch-show-mode-map "S"
+          (lambda ()
+            "mark message as spam"
+            (interactive)
+            (notmuch-show-tag-message "+spam" "-inbox")))
+
 You can do the same for threads in `notmuch-search-mode` by just
 replacing "show" with "search" in the called functions.
 
+(Starting from notmuch 0.12 use `notmuch-search-tag-thread` instead)
+
 The definition above makes use of a lambda function, but you could
 also define a separate function first:
 
@@ -159,6 +174,8 @@ also define a separate function first:
           (notmuch-show-remove-tag "inbox")))
         (define-key notmuch-show-mode-map "S" 'notmuch-show-tag-spam)
 
+(See above for analogy how to apply this for notmuch 0.12 and later)
+
 Here's a more complicated example of how to add a toggle "deleted"
 key:
 
@@ -170,6 +187,16 @@ key:
                 (notmuch-show-remove-tag "deleted")
               (notmuch-show-add-tag "deleted"))))
 
+And version for notmuch 0.12 (not released yet)
+
+        (define-key notmuch-show-mode-map "d"
+          (lambda ()
+            "toggle deleted tag for message"
+            (interactive)
+            (notmuch-show-tag-message
+              (if (member "deleted" (notmuch-show-get-tags))
+                  "-deleted" "+deleted"))))
+
 ## Restore reply-to-all key binding to 'r'
 
 Starting from notmuch 0.12 the 'r' key is bound to reply-to-sender instead of
@@ -371,7 +398,7 @@ part.
 
 ### Troubleshooting message-mode gpg support
 
-- If you have trouble with expired subkeys, you may have encounted
+- If you have trouble with expired subkeys, you may have encountered
   emacs bug #7931.  This is fixed in git commit 301ea744c on
   2011-02-02.  Note that if you have the Debian package easypg
   installed, it will shadow the fixed version of easypg included with