]> git.cworth.org Git - scherzo/commitdiff
Don't queue up as many widget redraws.
authorCarl Worth <cworth@cworth.org>
Mon, 26 Sep 2011 17:36:09 +0000 (10:36 -0700)
committerCarl Worth <cworth@cworth.org>
Mon, 26 Sep 2011 17:36:09 +0000 (10:36 -0700)
For multiple MIDI messages in a single buffer, only queue a single redraw.

GTK+ should be coalescing these anyway, but we might as well not make
it work any harder than it has too.

scherzo.c

index 88cae44fe4cdb85bde4669a41e713f463767915c..0ff68d125d17e072ff911ac28a351c36244f3b52 100644 (file)
--- a/scherzo.c
+++ b/scherzo.c
@@ -358,6 +358,7 @@ on_midi_input (unused (GIOChannel *channel),
     ssize_t remaining;
     snd_seq_event_t event;
     score_note_t *note;
+    int need_redraw = FALSE;
 
     remaining = read (scherzo->midi_fd, buf, MIDI_BUF_SIZE);
 
@@ -378,12 +379,12 @@ on_midi_input (unused (GIOChannel *channel),
        case SND_SEQ_EVENT_NOTEON:
            note = scherzo_add_note_midi (scherzo, event.data.note.note);
            _judge_note (scherzo, note);
-           gtk_widget_queue_draw (scherzo->window);
+           need_redraw = TRUE;
            break;
        case SND_SEQ_EVENT_NOTEOFF:
            scherzo_remove_note_midi (scherzo, event.data.note.note);
            _score_challenge (scherzo);
-           gtk_widget_queue_draw (scherzo->window);
+           need_redraw = TRUE;
            break;
        case SND_SEQ_EVENT_CLOCK:
            /* Ignore for now as my piano sends a constant stream of these. */
@@ -397,7 +398,10 @@ on_midi_input (unused (GIOChannel *channel),
            break;
        }
     }
-    
+
+    if (need_redraw)
+       gtk_widget_queue_draw (scherzo->window);
+
     /* Return TRUE to continue to get called in the future. */
     return TRUE;
 }